Strict Standards: Non-static method Flyspray::absoluteURI() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/includes/constants.inc.php on line 29 Strict Standards: Non-static method Flyspray::get_tmp_dir() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/includes/constants.inc.php on line 78 Strict Standards: Non-static method Flyspray::base_version() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/header.php on line 29 Strict Standards: Non-static method Flyspray::base_version() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/header.php on line 29 Strict Standards: Non-static method Req::val() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/header.php on line 39 Strict Standards: Non-static method Req::has() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/includes/class.gpc.php on line 26 Strict Standards: Non-static method Req::num() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/header.php on line 40 Strict Standards: Non-static method Req::val() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/includes/class.gpc.php on line 32 Strict Standards: Non-static method Req::has() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/includes/class.gpc.php on line 26 Strict Standards: Non-static method Filters::num() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/includes/class.gpc.php on line 32 Strict Standards: Non-static method Req::num() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/header.php on line 42 Strict Standards: Non-static method Req::val() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/includes/class.gpc.php on line 32 Strict Standards: Non-static method Req::has() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/includes/class.gpc.php on line 26 Strict Standards: Non-static method Filters::num() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/includes/class.gpc.php on line 32 Strict Standards: Non-static method Req::enum() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/index.php on line 15 Strict Standards: Non-static method Req::val() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/includes/class.gpc.php on line 37 Strict Standards: Non-static method Req::has() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/includes/class.gpc.php on line 26 Strict Standards: Non-static method Filters::enum() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/includes/class.gpc.php on line 37 Strict Standards: Non-static method Req::has() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/index.php on line 21 Strict Standards: Non-static method Req::has() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/index.php on line 21 Strict Standards: Non-static method Cookie::has() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/index.php on line 28 Strict Standards: Non-static method Get::val() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/index.php on line 36 Strict Standards: Non-static method Get::has() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/includes/class.gpc.php on line 100 Strict Standards: Non-static method Get::val() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/index.php on line 95 Strict Standards: Non-static method Get::has() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/includes/class.gpc.php on line 100 Strict Standards: Non-static method Flyspray::requestDuplicated() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/index.php on line 104 Strict Standards: Non-static method Req::has() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/index.php on line 143 Strict Standards: Non-static method Req::num() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/scripts/details.php on line 15 Strict Standards: Non-static method Req::val() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/includes/class.gpc.php on line 32 Strict Standards: Non-static method Req::has() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/includes/class.gpc.php on line 26 Strict Standards: Non-static method Filters::num() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/includes/class.gpc.php on line 32 Strict Standards: Non-static method Flyspray::GetTaskDetails() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/scripts/details.php on line 17 Strict Standards: Non-static method Flyspray::GetAssignees() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/includes/class.flyspray.php on line 358 Strict Standards: Non-static method Get::val() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/scripts/details.php on line 34 Strict Standards: Non-static method Get::has() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/includes/class.gpc.php on line 100 Strict Standards: Non-static method Post::has() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/scripts/details.php on line 34 Strict Standards: Non-static method TextFormatter::render() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/scripts/details.php on line 128 FS#1074 : Lyrics are no longer fetched from the internet.
homepage | forum | wiki | feature requests & bugs

MMS

Before posting a bug report please read: http://wiki.mymediasystem.org/wiki/index.php/Bug_reports
Tasklist

FS#1074 - Lyrics are no longer fetched from the internet.

Attached to Project: MMS
Opened by Strict Standards: array_map() expects parameter 1 to be a valid callback, non-static method Filters::noXSS() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/includes/class.tpl.php on line 281 Tobyn (tob) - Strict Standards: Non-static method Filters::noXSS() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/includes/class.tpl.php on line 613 Sunday, 12 September 2010, 00:00 GMT+2
Last edited by Strict Standards: array_map() expects parameter 1 to be a valid callback, non-static method Filters::noXSS() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/includes/class.tpl.php on line 281 Roman (Uatschitchun) - Strict Standards: Non-static method Filters::noXSS() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/includes/class.tpl.php on line 613 Monday, 20 September 2010, 12:06 GMT+2
Task Type Bug Report
Category Plugins → Audio → Lyrics
Status Requires testing
Assigned To Strict Standards: array_map() expects parameter 1 to be a valid callback, non-static method Filters::noXSS() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/includes/class.tpl.php on line 281 Pablo Castorino (castorinop)
Operating System Linux
Severity Low
Priority Normal
Reported Version 1.1.1
Due in Version Undecided
Due Date Undecided
Percent Complete 90%
Votes 0
Private No

Details

It looks like the lyric APIs have been changed again. I don't know how long it has been like this because cached lyrics are displayed properly.
This task depends upon

Comment by Roman (Uatschitchun) - Strict Standards: Non-static method Filters::noXSS() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/includes/class.tpl.php on line 613 Monday, 13 September 2010, 17:45 GMT+2
Confirm
Comment by Pablo Castorino (castorinop) - Strict Standards: Non-static method Filters::noXSS() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/includes/class.tpl.php on line 613 Monday, 13 September 2010, 17:48 GMT+2
i will work on it..
Comment by Roman (Uatschitchun) - Strict Standards: Non-static method Filters::noXSS() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/includes/class.tpl.php on line 613 Wednesday, 15 September 2010, 14:48 GMT+2
Pablo, have you got a clue on how long you need? Not to hurry you, but I would like to publish a new set of packages and want to wait until this one is fixed!
Comment by Pablo Castorino (castorinop) - Strict Standards: Non-static method Filters::noXSS() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/includes/class.tpl.php on line 613 Wednesday, 15 September 2010, 18:05 GMT+2
i wish can fixed for the weekend
Comment by Pablo Castorino (castorinop) - Strict Standards: Non-static method Filters::noXSS() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/includes/class.tpl.php on line 613 Sunday, 19 September 2010, 00:56 GMT+2
fixed fix fetch lyricwiki helper.
Comment by Pablo Castorino (castorinop) - Strict Standards: Non-static method Filters::noXSS() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/includes/class.tpl.php on line 613 Sunday, 19 September 2010, 01:22 GMT+2
Testing bundle for chartlyrics, please test and report problems.

Regards.
Comment by Tobyn (tob) - Strict Standards: Non-static method Filters::noXSS() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/includes/class.tpl.php on line 613 Sunday, 19 September 2010, 07:46 GMT+2
Excellent work Pablo!

No problems so far, but I'll continue testing.
Thank you very much for the fixes.
Comment by Roman (Uatschitchun) - Strict Standards: Non-static method Filters::noXSS() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/includes/class.tpl.php on line 613 Sunday, 19 September 2010, 12:18 GMT+2
1.) I do get graphic-failures like shown on the screenshot (it seems like it's an encoding problem ... characters like "'" do get displayed as "boxes")

2.) The lyrics scroll too far up, into the song-info

3.) Question: Do lyrics get fetched in a particular order? what lyrics-source is used in what order? leoslyrics, lyricwiki, chartlyrics ... 1st, 2nd, 3rd? Or am I able to set the order by hand?

4.) Lyrics do jump ... if a new line shows up at the bottom, the part of lyrics that were just displayed jump down ...
Comment by Roman (Uatschitchun) - Strict Standards: Non-static method Filters::noXSS() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/includes/class.tpl.php on line 613 Sunday, 19 September 2010, 17:27 GMT+2
Ok, I re-checked ...
problems 2.) & 4.) seem to be related to using mms with --enable-res-switch and trying lyrics in alternate resolution (orig-res 1680x1050 & alternate-res 800x600).

So lyrics doesn't seem to take the res-switch into account

Problems with 1.) do still exist!
Comment by Roman (Uatschitchun) - Strict Standards: Non-static method Filters::noXSS() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/includes/class.tpl.php on line 613 Sunday, 19 September 2010, 17:28 GMT+2
Problem with 1.) seem to be encoding:
lyrics/amy macdonald - don't tell me that it's over: data
lyrics/amy macdonald - this pretty face: ASCII English text
lyrics/amy macdonald - your time will come: ASCII English text
lyrics/amy macdonald - youth of today: ASCII English text
lyrics/audioslave - cochise: ASCII English text
lyrics/christina aguilera - bionic: ASCII English text
lyrics/la vela puerca - clarobscuro: UTF-8 Unicode text
lyrics/la vela puerca - de atar: UTF-8 Unicode text
lyrics/la vela puerca - dice: UTF-8 Unicode text
lyrics/la vela puerca - escobas: UTF-8 Unicode text
lyrics/la vela puerca - llenos de magia: UTF-8 Unicode text
lyrics/la vela puerca - sin palabras: UTF-8 Unicode text
lyrics/la vela puerca - va a escampar: UTF-8 Unicode text
lyrics/limp bizkit - nookie: ASCII English text
lyrics/metallica - the four horsemen: ASCII English text
lyrics/metallica - wherever i may roam: ASCII English text
lyrics/rage against the machine - bullet in the head: ASCII English text
lyrics/suicidal tendencies - pledge your allegiance: ASCII English text
lyrics/the gossip - heavy cross: ASCII English text

They should all be utf8 for to work correct ...
Comment by Pablo Castorino (castorinop) - Strict Standards: Non-static method Filters::noXSS() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/includes/class.tpl.php on line 613 Sunday, 19 September 2010, 17:41 GMT+2
1.) i looking this problem, and i think that solution is implement detect charset and convert to UTF, should be use a multibyte string lib (http://github.com/scottmac/libmbfl/tree/master/mbfl/) like use a php.
3.) don't is configurable. the order is: lyricwiki, chartlyricsm and leolyrics.

2.) some cases the boxes change the height of line. i think this will be solved when the problem charset are fixed.

res-switch have api ? or example of implement ?

btw, the lyrics fetch is resolved ?
Comment by Pablo Castorino (castorinop) - Strict Standards: Non-static method Filters::noXSS() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/includes/class.tpl.php on line 613 Sunday, 19 September 2010, 20:49 GMT+2
fixed null result bug (reported by roman at irc)
if chartlyrics work well, tell me and ulpoad the bundle without debug.

regards
Comment by Pablo Castorino (castorinop) - Strict Standards: Non-static method Filters::noXSS() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/includes/class.tpl.php on line 613 Sunday, 19 September 2010, 21:26 GMT+2
simplified bundle.

use mms-fix_lyricwiki.bundle.bzr + mms-fix_lyricwiki.bundle.002.bzr

regards!
Comment by Roman (Uatschitchun) - Strict Standards: Non-static method Filters::noXSS() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/includes/class.tpl.php on line 613 Monday, 20 September 2010, 12:05 GMT+2
For to make more people test, I uploaded the patch to upstream (revno 2272).
Pls report back!
Comment by Roman (Uatschitchun) - Strict Standards: Non-static method Filters::noXSS() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/includes/class.tpl.php on line 613 Sunday, 26 September 2010, 04:03 GMT+2
Attached you'll find a patch which enables 'timeout' and 'retries' within wget_wrapper and sets a timeout of 10s and 3 retries to lyrics_helpers. So with that, if a server doesn't respond, the others get asked.

Pls have a look and comment ;)
Comment by Roman (Uatschitchun) - Strict Standards: Non-static method Filters::noXSS() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/includes/class.tpl.php on line 613 Sunday, 26 September 2010, 14:09 GMT+2
1.) I don't get any lyrics from lyricswiki anymore ... the server doesn't respond on the querries?!

2.) chartlyrics fetches wrong lyrics (Tina Dico - In love and war):
LFH_chartlyrics::fetch() get url http://api.chartlyrics.com/apiv1.asmx/SearchLyricDirect?artist=tina+dico&song=in+love+and+war
LFH_chartlyrics::fetch() get
<GetLyricResult xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns="http://api.chartlyrics.com/">
<LyricChecksum>ef887b980b3617c57c74895dbfd9231f</LyricChecksum>
<LyricId>953</LyricId>
<LyricSong>What's Love Got to Do With It</LyricSong>
<LyricArtist>Tina Turner</LyricArtist>
<LyricUrl>http://www.chartlyrics.com/FN9ykB624kK09Gu7f9tVhg/What's+Love+Got+to+Do+With+It.aspx</LyricUrl>
<LyricCovertArtUrl>http://images.amazon.com/images/P/B000002U8I.01.MZZZZZZZ.jpg</LyricCovertArtUrl>
<LyricRank>9</LyricRank>
<LyricCorrectUrl>http://www.chartlyrics.com/app/correct.aspx?lid=OQA1ADMA</LyricCorrectUrl>
<Lyric>You must understand
Got to do with it</Lyric>
</GetLyricResult>

results in Tina Turner ;(

@Tobyn, does it work for you?
Comment by Pablo Castorino (castorinop) - Strict Standards: Non-static method Filters::noXSS() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/includes/class.tpl.php on line 613 Sunday, 26 September 2010, 17:00 GMT+2
chartlyrics don't provide exact match. is only for test purposes
Comment by Roman (Uatschitchun) - Strict Standards: Non-static method Filters::noXSS() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/includes/class.tpl.php on line 613 Sunday, 26 September 2010, 17:31 GMT+2
so I spam my .mms/lyrics folder with wrong lyrics? not nice!
Comment by Tobyn (tob) - Strict Standards: Non-static method Filters::noXSS() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/includes/class.tpl.php on line 613 Monday, 27 September 2010, 08:21 GMT+2
My lyrics are still being fetched properly. However, I have had a couple of crashes. I'll try and capture a core dump the next time it crashes.
Comment by Tobyn (tob) - Strict Standards: Non-static method Filters::noXSS() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/includes/class.tpl.php on line 613 Monday, 04 October 2010, 08:45 GMT+2
Here is a back trace of a crash. I think I was listening to Internet radio when it crashed. Thanks for the help.
Comment by Roman (Uatschitchun) - Strict Standards: Non-static method Filters::noXSS() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/includes/class.tpl.php on line 613 Friday, 08 October 2010, 21:26 GMT+2
Any news here?
Comment by Tobyn (tob) - Strict Standards: Non-static method Filters::noXSS() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/includes/class.tpl.php on line 613 Monday, 23 May 2011, 09:46 GMT+2
I finally looked in to the lyrics crash problem that I was having. Lyrics fetched from the web that started with a blank line would cause an infinite loop in lyrics_fetch.cpp. I also disabled the chartlyrics routine because it was producing the wrong lyrics.

I can't attach the diff for some reason so I'll post it instead:



*** /a/plugins/feature/audio/lyrics_fetch.cpp 2010-09-20 19:53:21.000000000 -0700
--- /b/plugins/feature/audio/lyrics_fetch.cpp 2011-05-22 23:57:36.063216333 -0700
***************
*** 53,58 ****
--- 53,59 ----
str_buffer = wiki.get_text();
}

+ /* Disable chartlyris because it returnes wrong lyrics
if (str_buffer.size() == 0) {
LFH_chartlyrics chart = LFH_chartlyrics(artist, title);
chart.fetch();
***************
*** 61,67 ****
str_buffer = chart.get_text();
}
}
!
if (str_buffer.size() == 0) {
LFH_leoslyrics leo = LFH_leoslyrics(artist, title);
leo.fetch();
--- 62,68 ----
str_buffer = chart.get_text();
}
}
! */
if (str_buffer.size() == 0) {
LFH_leoslyrics leo = LFH_leoslyrics(artist, title);
leo.fetch();
***************
*** 125,130 ****
--- 126,133 ----
while (cur_pos != std::string::npos && text.size() > 0) {
string::size_type nsec_length = (cur_pos == 0 ? 0 : nsec.size());
next_pos = text.find(nsec, cur_pos + nsec_length);
+ if (next_pos == cur_pos)
+ next_pos = text.find(nsec, cur_pos + nsec_length + 1);
if (cur_pos + nsec_length < text.size()) {
if (next_pos != std::string::npos)
buff = text.substr(cur_pos + nsec_length, next_pos - cur_pos - nsec_length);
Comment by Roman (Uatschitchun) - Strict Standards: Non-static method Filters::noXSS() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/includes/class.tpl.php on line 613 Monday, 23 May 2011, 21:43 GMT+2
could you post a unified diff?
Comment by Tobyn (tob) - Strict Standards: Non-static method Filters::noXSS() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/includes/class.tpl.php on line 613 Tuesday, 24 May 2011, 08:13 GMT+2
--- /a/plugins/feature/audio/lyrics_fetch.cpp 2010-09-20 19:53:21.000000000 -0700
+++ /b/plugins/feature/audio/lyrics_fetch.cpp 2011-05-22 23:57:36.063216333 -0700
@@ -53,6 +53,7 @@
str_buffer = wiki.get_text();
}

+/* Disable chartlyris because it returns wrong lyrics
if (str_buffer.size() == 0) {
LFH_chartlyrics chart = LFH_chartlyrics(artist, title);
chart.fetch();
@@ -61,7 +62,7 @@
str_buffer = chart.get_text();
}
}
-
+*/
if (str_buffer.size() == 0) {
LFH_leoslyrics leo = LFH_leoslyrics(artist, title);
leo.fetch();
@@ -125,6 +126,8 @@
while (cur_pos != std::string::npos && text.size() > 0) {
string::size_type nsec_length = (cur_pos == 0 ? 0 : nsec.size());
next_pos = text.find(nsec, cur_pos + nsec_length);
+ if (next_pos == cur_pos)
+ next_pos = text.find(nsec, cur_pos + nsec_length + 1);
if (cur_pos + nsec_length < text.size()) {
if (next_pos != std::string::npos)
buff = text.substr(cur_pos + nsec_length, next_pos - cur_pos - nsec_length);
Comment by Tobyn (tob) - Strict Standards: Non-static method Filters::noXSS() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/includes/class.tpl.php on line 613 Tuesday, 24 May 2011, 08:34 GMT+2
@Roman
I still can't attach files to this site and the indentation gets screwed up when I post the text so I emailed you the unified diff at mms@prodeia.de. Thanks.
Comment by Tobyn (tob) - Strict Standards: Non-static method Filters::noXSS() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/includes/class.tpl.php on line 613 Thursday, 01 September 2011, 10:10 GMT+2
Any update? did my patch ever get applied?
Comment by Strict Standards: array_map() expects parameter 1 to be a valid callback, non-static method Filters::noXSS() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/includes/class.tpl.php on line 281 lorenzodes (lorenzodes) - Strict Standards: Non-static method Filters::noXSS() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/includes/class.tpl.php on line 613 Thursday, 01 September 2011, 10:48 GMT+2
I'll apply your patch manually. Apparently flyspray is borked and doesn't accept attachments anymore.
Comment by lorenzodes (lorenzodes) - Strict Standards: Non-static method Filters::noXSS() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/includes/class.tpl.php on line 613 Thursday, 01 September 2011, 11:11 GMT+2
Please, check revno 2291.
Comment by Tobyn (tob) - Strict Standards: Non-static method Filters::noXSS() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/includes/class.tpl.php on line 613 Thursday, 01 September 2011, 17:41 GMT+2
Thanks lorenzodes!

Loading...