Strict Standards: Non-static method Flyspray::absoluteURI() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/includes/constants.inc.php on line 29 Strict Standards: Non-static method Flyspray::get_tmp_dir() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/includes/constants.inc.php on line 78 Strict Standards: Non-static method Flyspray::base_version() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/header.php on line 29 Strict Standards: Non-static method Flyspray::base_version() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/header.php on line 29 Strict Standards: Non-static method Req::val() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/header.php on line 39 Strict Standards: Non-static method Req::has() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/includes/class.gpc.php on line 26 Strict Standards: Non-static method Req::num() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/header.php on line 40 Strict Standards: Non-static method Req::val() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/includes/class.gpc.php on line 32 Strict Standards: Non-static method Req::has() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/includes/class.gpc.php on line 26 Strict Standards: Non-static method Filters::num() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/includes/class.gpc.php on line 32 Strict Standards: Non-static method Req::num() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/header.php on line 42 Strict Standards: Non-static method Req::val() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/includes/class.gpc.php on line 32 Strict Standards: Non-static method Req::has() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/includes/class.gpc.php on line 26 Strict Standards: Non-static method Filters::num() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/includes/class.gpc.php on line 32 Strict Standards: Non-static method Req::enum() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/index.php on line 15 Strict Standards: Non-static method Req::val() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/includes/class.gpc.php on line 37 Strict Standards: Non-static method Req::has() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/includes/class.gpc.php on line 26 Strict Standards: Non-static method Filters::enum() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/includes/class.gpc.php on line 37 Strict Standards: Non-static method Req::has() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/index.php on line 21 Strict Standards: Non-static method Req::has() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/index.php on line 21 Strict Standards: Non-static method Cookie::has() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/index.php on line 28 Strict Standards: Non-static method Get::val() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/index.php on line 36 Strict Standards: Non-static method Get::has() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/includes/class.gpc.php on line 100 Strict Standards: Non-static method Get::val() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/index.php on line 95 Strict Standards: Non-static method Get::has() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/includes/class.gpc.php on line 100 Strict Standards: Non-static method Flyspray::requestDuplicated() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/index.php on line 104 Strict Standards: Non-static method Req::has() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/index.php on line 143 Strict Standards: Non-static method Req::num() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/scripts/details.php on line 15 Strict Standards: Non-static method Req::val() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/includes/class.gpc.php on line 32 Strict Standards: Non-static method Req::has() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/includes/class.gpc.php on line 26 Strict Standards: Non-static method Filters::num() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/includes/class.gpc.php on line 32 Strict Standards: Non-static method Flyspray::GetTaskDetails() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/scripts/details.php on line 17 Strict Standards: Non-static method Flyspray::GetAssignees() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/includes/class.flyspray.php on line 358 Strict Standards: Non-static method Get::val() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/scripts/details.php on line 34 Strict Standards: Non-static method Get::has() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/includes/class.gpc.php on line 100 Strict Standards: Non-static method Post::has() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/scripts/details.php on line 34 Strict Standards: Non-static method TextFormatter::render() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/scripts/details.php on line 128 FS#840 : Graphical glitch with lyrics
homepage | forum | wiki | feature requests & bugs

MMS

Before posting a bug report please read: http://wiki.mymediasystem.org/wiki/index.php/Bug_reports
Tasklist

FS#840 - Graphical glitch with lyrics

Attached to Project: MMS
Opened by Strict Standards: array_map() expects parameter 1 to be a valid callback, non-static method Filters::noXSS() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/includes/class.tpl.php on line 281 Tobyn (tob) - Strict Standards: Non-static method Filters::noXSS() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/includes/class.tpl.php on line 613 Saturday, 18 October 2008, 10:00 GMT+1
Last edited by Strict Standards: array_map() expects parameter 1 to be a valid callback, non-static method Filters::noXSS() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/includes/class.tpl.php on line 281 lorenzodes (lorenzodes) - Strict Standards: Non-static method Filters::noXSS() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/includes/class.tpl.php on line 613 Sunday, 18 October 2009, 20:42 GMT+1
Task Type Bug Report
Category Plugins → Audio → Lyrics
Status Unconfirmed   Reopened
Assigned To Strict Standards: array_map() expects parameter 1 to be a valid callback, non-static method Filters::noXSS() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/includes/class.tpl.php on line 281 Pablo Castorino (castorinop)
Operating System Linux
Severity Medium
Priority Normal
Reported Version 1.1.0
Due in Version 1.1.2
Due Date Undecided
Percent Complete 0%
Votes 0
Private No

Details

Non-standard characters cause graphical problems in the lyrics screensaver.
This task depends upon

Comment by lorenzodes (lorenzodes) - Strict Standards: Non-static method Filters::noXSS() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/includes/class.tpl.php on line 613 Saturday, 18 October 2008, 14:43 GMT+1
There's also a locale problem.
Comment by lorenzodes (lorenzodes) - Strict Standards: Non-static method Filters::noXSS() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/includes/class.tpl.php on line 613 Saturday, 18 October 2008, 15:21 GMT+1
Ok, the locale problem is not a bug in mms:
http://api.leoslyrics.com/api_lyrics.php?auth=MMS&id=267235

The lyrics file is broken.
Comment by Tobyn (tob) - Strict Standards: Non-static method Filters::noXSS() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/includes/class.tpl.php on line 613 Sunday, 26 October 2008, 00:13 GMT+1
The attached lyric file produces the same bug.
Comment by lorenzodes (lorenzodes) - Strict Standards: Non-static method Filters::noXSS() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/includes/class.tpl.php on line 613 Sunday, 26 October 2008, 00:33 GMT+1
Well, it's more complicated than that.

That Lyrics file is broken. It contains valid UTF-8 multibyte sequences (and revno 1927/1928 checks that) that, alas, don't have a corresponding character in their pagecode. I see no solution.

This can't be fixed.
Comment by lorenzodes (lorenzodes) - Strict Standards: Non-static method Filters::noXSS() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/includes/class.tpl.php on line 613 Sunday, 26 October 2008, 02:10 GMT+1
You can fix the lyrics file though:

$ iconv -f utf-8 -t ISO-8859-1 <lyrics file> >/tmp/deleteme
$ mv /tmp/deleteme <lyrics file>

As I said, that file is broken: by converting it from UTF-8 to ISO-8859-1, you're actually converting it to the real UTF-8.
Comment by Tobyn (tob) - Strict Standards: Non-static method Filters::noXSS() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/includes/class.tpl.php on line 613 Sunday, 26 October 2008, 06:43 GMT+1
No problem, I'll fix my lyric file. Thanks for looking into it.
Comment by Tobyn (tob) - Strict Standards: Non-static method Filters::noXSS() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/includes/class.tpl.php on line 613 Wednesday, 07 October 2009, 08:21 GMT+1
I am having the same issue that I was having last year with a new album. I don't know if it's a coincidence or if it has to do with some of the work that has been done to the lyrics lately.
Comment by Strict Standards: array_map() expects parameter 1 to be a valid callback, non-static method Filters::noXSS() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/includes/class.tpl.php on line 281 Anders Rune Jensen (arj) - Strict Standards: Non-static method Filters::noXSS() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/includes/class.tpl.php on line 613 Monday, 12 October 2009, 22:15 GMT+1
Doesn't the locale fix work?
Comment by Tobyn (tob) - Strict Standards: Non-static method Filters::noXSS() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/includes/class.tpl.php on line 613 Monday, 12 October 2009, 22:38 GMT+1
Manually fixing the lyric file does work fine.
I thought that Lorenzodes applied a patch that resolved this issue when this bug was originally closed. Maybe I'm mistaken.

This is a very ugly bug. I think it would be best to fix it inside mms if it is possible. However, I realize that it is a rare bug, and I can fix my lyrics files if it's to complicated. Thanks for looking into the problem.
Comment by Anders Rune Jensen (arj) - Strict Standards: Non-static method Filters::noXSS() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/includes/class.tpl.php on line 613 Tuesday, 13 October 2009, 23:03 GMT+1
It shouldn't be that hard to fix. We already have local support in the config files. That is used for like id3 tags. I'm not sure if screensaver uses that or not since I didn't write it.
Comment by lorenzodes (lorenzodes) - Strict Standards: Non-static method Filters::noXSS() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/includes/class.tpl.php on line 613 Sunday, 18 October 2009, 20:40 GMT+1
If the lyric file is advertised by the web server as coded in UTF-8 while it is not, there's nothing we can do.
Comment by lorenzodes (lorenzodes) - Strict Standards: Non-static method Filters::noXSS() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/includes/class.tpl.php on line 613 Sunday, 18 October 2009, 20:41 GMT+1
Tobyn:

Mms should print to console the url that uses to retrieve that lyric file. Can you please post it here so that I can check?
Comment by Tobyn (tob) - Strict Standards: Non-static method Filters::noXSS() should not be called statically in /var/kunden/webs/mms/flyspray-0.9.9.6/includes/class.tpl.php on line 613 Monday, 19 October 2009, 07:12 GMT+1
Here is the link:
http://api.leoslyrics.com/api_lyrics.php?auth=MMS&hid=b5d6zW1pF80%3d

Can't we test for bad characters and not save them to file, or not print them to screen?

Loading...